ui: fix computer diagram css margin that blocks down arrow#3225
Merged
yadvr merged 1 commit intoapache:masterfrom Apr 11, 2019
Merged
ui: fix computer diagram css margin that blocks down arrow#3225yadvr merged 1 commit intoapache:masterfrom
yadvr merged 1 commit intoapache:masterfrom
Conversation
This fixes the UI issue where down arrow key of the list of template/offerings etc is not press-able due to horizontal margin of the computer diagram spilling on the left in the VM deployment wizard. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
changed the title
Contributor
Contributor
|
I double checked this, and the down arrow is also not clickable with #3183. So this is no duplicate @rhtyd |
Member
Author
|
Thanks @DennisKonrad |
DaanHoogland
approved these changes
Mar 13, 2019
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
I wish a more relative and abstract way of positioning sprung to mind. LGTM
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2636 |
yadvr
changed the title
borisstoyanov
approved these changes
Mar 29, 2019
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, confirmed this manually
|
LGTM |
yadvr
changed the title
Contributor
|
Whohoo - finally :) |
pbankonier
pushed a commit
to pbankonier/cloudstack
that referenced
this pull request
Apr 24, 2019
Problem: Down arrow key of the vertical scroll bar in the VM deployment wizard does not work. Root Cause: The computer diagram on the right side in the VM deployment wizard spills its margin on the left causing the arrow key to be blocked. Solution: Fix the background-position to get the correct position than margin-left for the zone-panel. With the fix, the left size arrow keys and vertical scrollbars are no longer under the diagram image and press-able now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Down arrow key of the vertical scroll bar in the VM deployment wizard does not work.
Root Cause: The computer diagram on the right side in the VM deployment wizard spills its margin on the left causing the arrow key to be blocked.
Solution: Fix the
background-positionto get the correct position thanmargin-leftfor thezone-panel. With the fix, the left size arrow keys and vertical scrollbars are no longer under the diagram image and press-able now.Types of changes
Screenshots (if appropriate):
Before the fix, as seen from dev tools:
The layout as seen in dev tools after the fix:
